[Date Prev][Date Next][Thread Prev][Thread Next][Thread Index]

RE: [XaraXtreme-dev] Re: [XaraXtreme-commits] Commit Complete

I wouldn't exactly call wx/tooltip.h a system header file.

This was a problem when trying to test my string changes on windows
because wx/setup.h hasn't been included yet so wxUSE_TOOLTIPS isn't
defined and this causes the tooltip.h header file to skip everything.
Presumably it works on linux because all those things get defined on the
command line rather than pulled in by wx/setup.h


-----Original Message-----
From: owner-dev@xxxxxxxxxxxxxxxx [mailto:owner-dev@xxxxxxxxxxxxxxxx] On
Behalf Of Alex Bligh
Sent: 19 April 2006 14:45
To: xara-dev
Cc: Alex Bligh
Subject: [XaraXtreme-dev] Re: [XaraXtreme-commits] Commit Complete


What's the reason for the change below? Surely we should be including
system includes first (that's the normal way of doing things) not least
because camtypes may want to (re)define them?


--On 19 April 2006 14:37 +0100 subversion@xxxxxxxxxxxxxx wrote:

> Index: Trunk/XaraLX/wxOil/dlgmgr.cpp
> ===================================================================
> --- Trunk/XaraLX/wxOil/dlgmgr.cpp	(revision 837)
> +++ Trunk/XaraLX/wxOil/dlgmgr.cpp	(revision 838)
> @@ -98,10 +98,11 @@
>  // Implementation of the DialogManager class (bodge central)
> +// Include files
> +#include "camtypes.h"
> +
>  #include <wx/tooltip.h>
> -// Include files
> -#include "camtypes.h"
>  #include "dlgmgr.h"
>  #include "dialogop.h"
>  //#include "simon.h"