[Date Prev][Date Next][Thread Prev][Thread Next][Thread Index]

RE: [XaraXtreme-dev] Tabbed dialogs



Title: RE: [XaraXtreme-dev] Tabbed dialogs

> In wxOil/dlgmgr.cpp, in DialogManager::Create(),  you've added this:
>
>       if( ok &&
>               Mode == MODAL &&
>               ( pDialogWnd->IsKindOf( CLASSINFO(wxDialog) ) ||
>                 DlgOp->IS_KIND_OF(DialogTabOp) ) ) // <--- this line
>       {
>               ((wxDialog *) pDialogWnd)->ShowModal();
>       }
>
> Why do a ShowModal() on a DialogTabOp() if it is non-modal? Surely
> it should be shown as per any non-modal tabbed dialog?

Alex,

I don't think think it will be called if Mode isn't MODAL. I think the test is
"if OK and MODAL and ( wxDialog or DialogTabOP )". Unless you've actually seen
this happen.....

    Luke