[Date Prev][Date Next][Thread Prev][Thread Next][Thread Index]

[XaraXtreme-dev] RE: [XaraXtreme-commits] Commit Complete

Alex (and Luke),

Your fix for this is fine for normal typing but it is still very slow
when using delete or backspace (the rendering doesn't keep up).  Also,
shift and cursor to select characters behaves very oddly with big pauses
in the auto-repeat.  I suppose these could be issues with the key
handling.  Does it handle delete and backspace differently to other
keys?  Does it do anything strange when shift is down?

These could be issues only in debug builds but as autorepeat typing
keeps up, I would expect delete and selection to keep up too...


-----Original Message-----
From: owner-commits@xxxxxxxxxxxxxxxx
[mailto:owner-commits@xxxxxxxxxxxxxxxx] On Behalf Of
Sent: 16 May 2006 23:53
To: commits@xxxxxxxxxxxxxx
Subject: [XaraXtreme-commits] Commit Complete

Commit by  : alex
Repository : xara
Revision   : 1091
Date       : Tue May 16 23:53:24 BST 2006

Changed paths:
   M /Trunk/XaraLX/Kernel/statline.h
   M /Trunk/XaraLX/wxOil/progress.cpp

Finally fixed slow text tool rendering

Index: Trunk/XaraLX/Kernel/statline.h
--- Trunk/XaraLX/Kernel/statline.h	(revision 1090)
+++ Trunk/XaraLX/Kernel/statline.h	(revision 1091)
@@ -208,9 +208,11 @@
 	BOOL ShowProgress (BOOL Show=TRUE, StringBase *JobDescrip =
-	INT32 GetPercent(void) const {return CurrentPercent;}
+	INT32 GetPercent() const {return CurrentPercent;}
 	BOOL SetPercent(INT32 Percent, BOOL RedrawBackground = FALSE,
StringBase *JobDescrip = NULL);
+	BOOL IsProgressShown() const {return ProgressShown;}
 	INT32 CurrentPercent;			// The currently
displayed percentage value
 	String_256 *JobDescription;	// NULL, or pointer to
description of current job
Index: Trunk/XaraLX/wxOil/progress.cpp
--- Trunk/XaraLX/wxOil/progress.cpp	(revision 1090)
+++ Trunk/XaraLX/wxOil/progress.cpp	(revision 1091)
@@ -849,7 +849,7 @@
 	if (ActiveDisplays > 0)
-	if (StatusLine::Get() && CurrentPercent < 97)
+	if (StatusLine::Get() && StatusLine::Get()->IsProgressShown() &&
CurrentPercent < 97)
 		// We are showing a progress bar, but have not shown
"completion" of the job (99%)
 		// Briefly jump to 99% on the progress bar so the user
can't see how bad our estimate