[Date Prev][Date Next][Thread Prev][Thread Next][Thread Index]

RE: [XaraXtreme-dev] Galleries and focus handling

> > Apply buttons in modeless dialogs. Er, in fact of course 
> > our galleries have Apply buttons.
> Yes but they do a different thing. They apply a selected 
> gallery item to the document selection. They don't apply 
> something you've changed in the dialog to the selection.

Er, what? Yes they do. I select a new font and click Apply. That applies
the newly selected settings in the gallery to the selection in the
document. That sounds exactly the same as the Align dialog to me.

> It's also confusing them being called apply. The fill gallery 
> calls them "Transp" and "Fill".

Yes, but that's just because there's no room to put 'Apply as fill' and
'Apply as transparency' (but I hope the tool tips make it clear).

> The colour gallery calls the 
> button "Apply" when it should be called "Fill" (and there 
> should be a "Line" button there),

Yep agree and the tooltips should say 'Apply as fill color' and 'Apply
as line color'

> In a conventional
Insert <non-modal>
> dialog, you'd expect changing the (document) 
> selection to be reflect in the dialog. And (if there's an 
> apply button) for any alterations to that to be reflected in 
> the document.

These can all be enhancements for future versions.

> > But right now I'll revert to the original goal again, to 
> port what's there, as close as we can to what's there
> I actually don't care hugely as to WHAT we implement, so long 
> as we have a consistent set of rules. Phil's rules were a 
> good start but didn't specify the entire behaviour. 

Well I think they do describe a set of rules than can be applied to
almost all modeless dialogs, bars and galleries. There are only minor
tweaks to those rules, if any.

> If there are specific 
> dialogs that should do things differently, let's hear why 
> they should deviate from Phil's rules.

I think the only glaring problem is the Options dialog, and even that
could probably be bent to fit Phil's rules without having to make it

> The align dialog is /not/ a special case. As far as I can see 
> on LX, all non-modal dialogs apart from the colour editor, 
> galleries, and bars perform identically to the align dialog 
> (see the options dialog for instance).

No it's not and exception, and it should perform like the colour gallery
and follow Phil's rules. If we make all the others follow the rules what
is the cost? What valuable features do we lose?

> While I remember, half the key shortcuts (and modifiers) seem 
> to be window manager settings which the app can't override 
> (or can't easily override). If possible, it would be useful 
> to highlight these ("your evil window manager has stolen 
> ALT-CLICK" etc.)

Highlight how?  Warning on start-up?

I'd like to find cross platform solutions to the Alt-click problem (e.g.
use the Windows key in parallel with the Alt key)