[Date Prev][Date Next][Thread Prev][Thread Next][Thread Index]

Re: [XaraXtreme-dev] Font dropdown fix

Martin Wuerthner wrote:
Find attached below a proposed fix for bug 1057. It adds a transient entry to the font dropdown list while a substituted font is the current font. This allows the font name (followed by "(missing)") to be displayed.


The string " (missing)" is currently a literal in the code. Do I need to do anything special to expose it for translation?

Yes you do. I committed it as a separate patch - see below.


Index: Trunk/XaraLX/wxOil/xrc/EN/xaralxonly-strings.xrc
--- Trunk/XaraLX/wxOil/xrc/EN/xaralxonly-strings.xrc	(revision 1164)
+++ Trunk/XaraLX/wxOil/xrc/EN/xaralxonly-strings.xrc	(revision 1165)
@@ -335,6 +335,12 @@
 					<label>Generate Error &Report</label>
+			<object class="sizeritem">
+				<flag>wxALIGN_LEFT|wxALL|wxADJUST_MINSIZE</flag>
+				<object class="wxStaticText" name="IDS_FONTMISSING">
+					<label> (missing)</label>
+				</object>
+			</object>
Index: Trunk/XaraLX/wxOil/fontdrop.cpp
--- Trunk/XaraLX/wxOil/fontdrop.cpp	(revision 1164)
+++ Trunk/XaraLX/wxOil/fontdrop.cpp	(revision 1165)
@@ -498,7 +498,8 @@
 		TRACEUSER("wuerthne", _T("font not in list, Index = %d"), Index);
 		// font was not in the list, so make sure there is a special item at the
 		// end to accomodate it
-		String_64 NewName(TheFont->FontName + _T(" (missing)"));
+		String_64 NewName(TheFont->FontName);
+		NewName += String_64(_R(IDS_FONTMISSING));
 		if (m_MissingItemAdded)