[Date Prev][Date Next][Thread Prev][Thread Next][Thread Index]

Re: [XaraXtreme-dev] Hello Xara!


great to see someone hacking on XaraLX. Just a hint: Usually
contributions are most appreciated when they come in form of a patch
against the latest SVN version (i.e., the output of svn diff -u).

I also hope that you’ll contribution will be accepted.

[The XaraLX Debian package maintainer]

Am Donnerstag, den 24.05.2007, 19:33 -0400 schrieb JLM:
> Hi, I enjoy Xara LX, and I also like programming so I decided to help
> out with some development. My first contribution is rather simple, I
> guess the equivalent of a "Hello World".
> I am using a non-standard GTK theme. This one has light text on a dark
> background. I have found that some parts of Xara's UI are illegible
> because they expect dark text on a light background. These changes
> should accommodate any GTK theme.
> First, in the Gallery dialog the background is white, but any text or
> even any line attributes in the line gallery are in the GTK theme's text
> color. This makes it very difficult to read using my theme. After some
> investigation I discovered that the text background color Xara is
> obtaining from wxWidgets is wxSYS_COLOUR_WINDOW. wxWidgets always
> returns white for that value. I think the more appropriate enum is
> wxSYS_COLOR_BACKGROUND. So in wxOil/dlgcol.cpp on line 207 change it from:
> GetOSColour(&mTextBack, wxSYS_COLOUR_WINDOW);
> to
> GetOSColour(&mTextBack, wxSYS_COLOUR_BACKGROUND);
> Second, also in the Gallery dialog, the lines that contain the folder
> icon and some text are also difficult to read. This is because the
> background color is being forced to 192,192,192, but the foreground
> color used is the theme's color. If the background color should be light
> then the foreground color should be dark. This change forces the text on
> these lines to black. In Kernel/sgtree.cpp I added these lines after 5006:
>           DocColour TextCol(COLOUR_BLACK);
>           Col.SetSeparable(FALSE);
> And then on line 5062 (was 5059) I changed from:
> RedrawInfo->Renderer->SetFixedSystemTextColours(&RedrawInfo->Foreground,
> &Col);
> to
> RedrawInfo->Renderer->SetFixedSystemTextColours(&TextCol, &Col);
> I see also that a number of drop-down selectors have white backgrounds,
> but my theme's text color, so I will tackle that problem next. I hope
> you'll accept my contribution.
> Thanks.

Joachim "nomeata" Breitner
Debian Developer
  nomeata@xxxxxxxxxx | ICQ# 74513189 | GPG-Keyid: 4743206C
  JID: joachimbreitner@xxxxxxxxxxx | http://people.debian.org/~nomeata